Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config.yaml includes explicit container versions, maybe it should not #713

Closed
rfay opened this issue Mar 6, 2018 · 0 comments
Closed

config.yaml includes explicit container versions, maybe it should not #713

rfay opened this issue Mar 6, 2018 · 0 comments

Comments

@rfay
Copy link
Member

rfay commented Mar 6, 2018

What happened (or feature request):

  • config.yaml (as created by ddev config includes explicit web and nginx image versions.
  • If you leave those explicit definitions out, then the versions specified by ddev are used by all commands.
  • If you ddev config with an existing project, all the container versions are updated (whether or not they were empty before).

There are a number of good things about this approach:

  • If people check in or otherwise respect.ddev/config.yaml, they can expect ddev behavior to be unchanged and unaffected by ddev version upgrades.

Bad things about this approach:

  • ddev upgrades don't automatically result in the required upgrade for the project. This can occasionally be bad, when ddev expects a new behavior and the older container doesn't provide it, or when the user is expecting to automatically have new ddev features.

Paths forward:

  • Leave as is
  • Stop unconditionally writing the version to config.yaml (but respect if it's there).

I would prefer to go forward with not populating those in the .config.yaml, but providing them as commented-out options. The related problem is that we need to rewrite docker-compose.yml all the time (on every start) to properly respect ddev and container upgrades.

This is closely related to our long-running discussion about who owns what in .ddev.

What you expected to happen:

How to reproduce this:

Version: Please include the output of ddev version, docker version and the project's .ddev/config.yaml.

Anything else do we need to know:

Related source links or issues:

Please use a complexity rating of 1-5 (5 is high) for a feature request. (High complexity implies more PR planning)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants