Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve nightly build to build all PRs and build containers #730

Closed
rfay opened this issue Mar 13, 2018 · 2 comments
Closed

Improve nightly build to build all PRs and build containers #730

rfay opened this issue Mar 13, 2018 · 2 comments
Assignees
Milestone

Comments

@rfay
Copy link
Member

rfay commented Mar 13, 2018

What happened (or feature request):

In #722 we removed the git submodules that were used for a full nightly build, so now although we have a nightly build it does nothing more than a regular build.

As a followup task we want to improve the nightly build to:

  • Build all open PRs
  • Build the containers and test with them.

What you expected to happen:

How to reproduce this:

Version: Please include the output of ddev version, docker version and the project's .ddev/config.yaml.

Anything else do we need to know:

Related source links or issues:

Please use a complexity rating of 1-5 (5 is high) for a feature request. (High complexity implies more PR planning)

@rickmanelius
Copy link
Contributor

I'm assuming this is a relatively high priority to ensure our test coverage is meaningful.

@rfay
Copy link
Member Author

rfay commented Mar 16, 2018

Nice to have, but not sure it has to be super-high priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants