Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize nginx configs to share most elements #849

Closed
rfay opened this issue May 14, 2018 · 1 comment
Closed

Reorganize nginx configs to share most elements #849

rfay opened this issue May 14, 2018 · 1 comment
Labels
Prioritized We expect to do this in an upcoming release
Milestone

Comments

@rfay
Copy link
Member

rfay commented May 14, 2018

From @rfay on March 22, 2018 21:2

What happened (or feature request):

Currently the entire nginx config is repeated for every project type, which is unnecessary and confusing and hard to maintain. They should be reorganized so that only the key things that are different are in the separate configs.

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else do we need to know:

Related source links or issues:

Copied from original issue: drud/docker.nginx-php-fpm-local#63

@rfay
Copy link
Member Author

rfay commented May 14, 2018

A key aspect of this task is to make it easier for our users to make small changes to the config. However, we have to make it so they can understand the big picture if they need to.

@rfay rfay added the Prioritized We expect to do this in an upcoming release label Apr 21, 2019
@rfay rfay added this to the v1.8.0 milestone Apr 22, 2019
@rfay rfay closed this as completed in 97c660a Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prioritized We expect to do this in an upcoming release
Projects
None yet
Development

No branches or pull requests

1 participant