Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/arch:AVX causes a crash on some older CPU models #52

Closed
Malacath-92 opened this issue Aug 17, 2021 · 1 comment · Fixed by #68
Closed

/arch:AVX causes a crash on some older CPU models #52

Malacath-92 opened this issue Aug 17, 2021 · 1 comment · Fixed by #68

Comments

@Malacath-92
Copy link

With this instruction set the MSVC emits unconditional usage of the instructions vpxor and vmovdqu when constructing a std::shared_ptr. On older CPU models that don't support the AVX instruction set this will result in a crash. It was quite frustrating to figure this out given that less than 1% of my users appear to be affected.
Maybe this instruction set could not be unconditionally applied to libnyquist when built from CMake? Or maybe the usage of std::shared_ptr can be reduced. Given that all decoders are stateless and 1-byte large there's next to not good reason to use std::shared_ptr for their storage. Although it has been a while since I worked with C++11, maybe something prevents you from avoid that.

@Malacath-92
Copy link
Author

This project had changes since this issue was reported. It's a tiny change that doesn't warrant a PR. Is anyone gonna fix it or are you just gonna leave the responsibility of it on your users?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant