Skip to content

Commit

Permalink
avoid uncoverable code by not using gemspec in Gemfile (#33)
Browse files Browse the repository at this point in the history
  • Loading branch information
grosser authored and ddnexus committed May 31, 2018
1 parent a585fe6 commit a09558e
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 19 deletions.
2 changes: 1 addition & 1 deletion .rubocop.yml
Expand Up @@ -10,7 +10,7 @@ Metrics:
Style:
Enabled: false

Gemspec/OrderedDependencies:
Bundler/OrderedGems:
Enabled: false

Naming/UncommunicativeMethodParamName:
Expand Down
12 changes: 11 additions & 1 deletion Gemfile
Expand Up @@ -2,6 +2,16 @@ source "https://rubygems.org"

git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }

gemspec
gem 'bundler', '~> 1.16'
gem 'rake', '~> 10.0'
gem 'minitest', '~> 5.0'
gem 'rack'
gem 'slim'
gem 'haml'
gem 'benchmark-ips'
gem 'kalibera'
gem 'memory_profiler'
gem 'rubocop', '~> 0.55.0' # needs to be fixed since it constantly adds new cops


gem "github-pages", group: :jekyll_plugins
6 changes: 0 additions & 6 deletions Gemfile.lock
@@ -1,8 +1,3 @@
PATH
remote: .
specs:
pagy (0.8.1)

GEM
remote: https://rubygems.org/
specs:
Expand Down Expand Up @@ -287,7 +282,6 @@ DEPENDENCIES
kalibera
memory_profiler
minitest (~> 5.0)
pagy!
rack
rake (~> 10.0)
rubocop (~> 0.55.0)
Expand Down
11 changes: 0 additions & 11 deletions pagy.gemspec
Expand Up @@ -14,17 +14,6 @@ Gem::Specification.new do |s|
s.files = `git ls-files -z`.split("\x0").select{|f| f.start_with?('lib', 'pagy.gemspec', 'LICENSE') }
s.required_ruby_version = '>= 2.3.0'

s.add_development_dependency 'bundler', '~> 1.16'
s.add_development_dependency 'rake', '~> 10.0'
s.add_development_dependency 'minitest', '~> 5.0'
s.add_development_dependency 'rack'
s.add_development_dependency 'slim'
s.add_development_dependency 'haml'
s.add_development_dependency 'benchmark-ips'
s.add_development_dependency 'kalibera'
s.add_development_dependency 'memory_profiler'
s.add_development_dependency 'rubocop', '~> 0.55.0' # needs to be fixed since it constantly adds new cops

# remove after 1.0
s.post_install_message = "Pagy CHANGELOG: https://github.com/ddnexus/pagy/blob/master/CHANGELOG.md"
end

0 comments on commit a09558e

Please sign in to comment.