Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forego inside forego #71

Closed
chenliu0831 opened this issue Nov 9, 2015 · 4 comments
Closed

forego inside forego #71

chenliu0831 opened this issue Nov 9, 2015 · 4 comments

Comments

@chenliu0831
Copy link
Contributor

I could be wrong but in foreman, if I start a procfile which contains another foreman start, it seems to be managed by the master foreman process (i.e. sigterms can be propagated). It looks like this is not true under forego anymore (it spawns separate process).

Not sure if this is a design choice or there's some other flags to support it.
@alexw23
Copy link

alexw23 commented Dec 29, 2015

👍

@jacebrowning
Copy link

👍

I would also find this behavior useful. I had to switch back to honcho for this reason.

@alexw23
Copy link

alexw23 commented Dec 30, 2015

I had to switch back to foreman, it seems to handle it better.

@ddollar
Copy link
Owner

ddollar commented Apr 23, 2016

Seems like an interesting case. If anyone is interested in submitting a PR to fix this I'd definitely take a look.

@ddollar ddollar closed this as completed Apr 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ddollar @jacebrowning @chenliu0831 @alexw23