Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons in Header Component don't have unique key props #1

Closed
bigsaigon333 opened this issue May 11, 2021 · 0 comments · Fixed by #2
Closed

Icons in Header Component don't have unique key props #1

bigsaigon333 opened this issue May 11, 2021 · 0 comments · Fixed by #2
Labels
good first issue Good for newcomers

Comments

@bigsaigon333
Copy link
Contributor

bigsaigon333 commented May 11, 2021 •
edited

Hi there! I really appreciate sharing your amazing madal-art!!

I found that icons in header component don't have unique key props and I got this warning.

image

I think we can use an index of array as key because its order never changes.
@bigsaigon333 bigsaigon333 mentioned this issue May 11, 2021
Merged
@bigsaigon333 bigsaigon333 changed the title Icons in Header Component don't have unique keys Icons in Header Component don't have unique key props May 11, 2021
@ddongule ddongule added the good first issue Good for newcomers label May 11, 2021
@ddongule ddongule linked a pull request May 11, 2021 that will close this issue
fix: add unique key prop to icons in Header #2
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add unique key prop to icons in Header bigsaigon333/mandal-art
2 participants
@ddongule @bigsaigon333