Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Alternative for getContent() #6

Closed
ayacoo opened this issue Jan 5, 2021 · 2 comments
Closed

Suggestion: Alternative for getContent() #6

ayacoo opened this issue Jan 5, 2021 · 2 comments

Comments

@ayacoo
Copy link

ayacoo commented Jan 5, 2021

Code:
https://github.com/ddoronenko/google-reviews/blob/master/Classes/Service/PlaceService.php#L115

It might be better to use the core methods, because you can fall back on TYPO3 settings. Think here, for example, of a proxy or similar options. The global timeout is then also used, etc.

Doc:
https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/ApiOverview/Http/Index.html

@ddoronenko
Copy link
Owner

@ayacoo I agree with you, TYPO3 core methods are preferable.

I'll check and add in the next release.

@ddoronenko
Copy link
Owner

@ayacoo

Changes are added in the new 2.0 EXT version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants