Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

write lua that forces no cmod #97

Closed
ianklatzco opened this issue Jan 28, 2019 · 4 comments
Closed

write lua that forces no cmod #97

ianklatzco opened this issue Jan 28, 2019 · 4 comments

Comments

@ianklatzco
Copy link
Member

ianklatzco commented Jan 28, 2019 •
edited

summary:

  • mod our version of simply love to check if the title or subtitle of the song contains no cmod
  • if a player selected cmod, automatically convert it to a mmod

image
image
@ianklatzco
Copy link
Member Author

https://github.com/nayotodot/StepMania-Mods-Template/blob/master/5.0/background/mods.lua?fbclid=IwAR0ZQb25NkOxUJDCo0AEFE4_hflXyqi0ldl90IBJ8WEE72fnwStqt7DmeiY#L103-L116

@andrewipark
Copy link
Member

closing b/c active PR

@ianklatzco
Copy link
Member Author

in most standard github interactions i’ve seen on other projects, you tie the issue to the PR by mentioning the issue number in the PR. then, when you merge the PR, it usually auto closes the issue (regex match)

@ianklatzco ianklatzco reopened this Feb 28, 2019
@ianklatzco
Copy link
Member Author

see ddrillini/Simply-Love-SM5#10
ddrillini/Simply-Love-SM5#30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ianklatzco @andrewipark