Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Support for multi-components models #1540

Open
larmarange opened this issue Aug 4, 2023 · 2 comments
Open

Feature request: Support for multi-components models #1540

larmarange opened this issue Aug 4, 2023 · 2 comments

Comments

@larmarange
Copy link
Collaborator

larmarange commented Aug 4, 2023

Dear @ddsjoberg

I'm currently adding support for zero-inflated models in broom.helpers, cf. larmarange/broom.helpers#233

With such models, you end-up with two sets of coefficients, for the two components of the model (see component column in the tidy table).

The situation is quite similar with multinomial models and their "y.level" column. Could we add support in tbl_regression() using the code already written for multinomial models?

Best regards

@ddsjoberg
Copy link
Owner

Absolutely! 🚀 🚀 🚀

@larmarange larmarange changed the title Feature request: Support for zero-inflated models Feature request: Support for multi-components models Aug 5, 2023
@larmarange
Copy link
Collaborator Author

betarag models are also multicomponent models. Therefore, we should be more general.

More precisely, we should check (1) if there is a "component" column in the result returned by tidy_plus_plus(), (2) if there is at least two different values in this col (with the selection of certain variables, removal of intercepts, etc. we could end up with just one value). If this is the case, then the tbl should be presented in a similar way as multinomial models.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants