Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tbl_survival to handle cuminc from cmprsk package #64

Closed
michaelcurry1123 opened this issue Apr 12, 2019 · 6 comments · Fixed by #472
Closed

tbl_survival to handle cuminc from cmprsk package #64

michaelcurry1123 opened this issue Apr 12, 2019 · 6 comments · Fixed by #472
Assignees
Labels
enhancement 🌟 New feature or request
Milestone

Comments

@michaelcurry1123
Copy link
Collaborator

This will allow people to get cumulative incidence for competing risks for each event.

@michaelcurry1123 michaelcurry1123 added the enhancement 🌟 New feature or request label Apr 12, 2019
@ddsjoberg
Copy link
Owner

ddsjoberg commented Apr 12, 2019

I think that is a very good idea! I can make tbl_survival a generic to accept survfit objects and cuminc objects.

@ddsjoberg ddsjoberg added the help wanted Extra attention is needed label Apr 13, 2019
@ddsjoberg
Copy link
Owner

I'll update tbl_survival() to be an S3 generic, and create tbl_survival.survfit(). @michaelcurry1123 would you be interested in writing tbl_survival.cuminc()?

We'll also need to update inline_text.tbl_survival() or ensure the output from tbl_survival.survfit() and tbl_survival.cuminc() are identical so the current version of inline_text.tbl_survival() will still work properly.

@michaelcurry1123
Copy link
Collaborator Author

@ddsjoberg Yes I am interested in that. I know tidy::broom does not support cuminc objects but I do have a function that might help.

@ddsjoberg
Copy link
Owner

Nice! I created this branch for the update:
https://github.com/ddsjoberg/gtsummary/tree/tbl_survival-cuminc

I made the tbl_survival S3 generic.

@ddsjoberg ddsjoberg changed the title should tbl_survival handle cuminc from cmprsk package tbl_survival to handle cuminc from cmprsk package Apr 13, 2019
@ddsjoberg
Copy link
Owner

Rather than update that branch I mentioned above, can you fork and make the update on your fork?

@ddsjoberg ddsjoberg removed the help wanted Extra attention is needed label Apr 14, 2019
@ddsjoberg
Copy link
Owner

for now, let's only support a single stratification level

@ddsjoberg ddsjoberg added this to the v0.1 Release milestone Apr 25, 2019
@ddsjoberg ddsjoberg removed this from the v0.1 Release milestone May 4, 2019
@ddsjoberg ddsjoberg added this to the v1.3.1 milestone May 17, 2020
@ddsjoberg ddsjoberg modified the milestones: v1.3.1, 1.3.2 Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🌟 New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants