Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make panel icon symbolic #323

Closed
pesader opened this issue Feb 1, 2023 · 3 comments
Closed

Make panel icon symbolic #323

pesader opened this issue Feb 1, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@pesader
Copy link
Contributor

pesader commented Feb 1, 2023

On some third-party icon themes the current panel icon doesn't look like an icon you would typically find in the panel but do provide an icon that does. Here's an example with the very popular Papirus icon theme:

utilities-terminal utilities-terminal-symbolic
Screenshot from 2023-01-29 20-45-15 Screenshot from 2023-01-29 20-46-45

I would be nice to be able to configure that in the Panel preferences.

@pesader pesader added the enhancement New feature or request label Feb 1, 2023
@amezin
Copy link
Member

amezin commented Sep 22, 2023

Hm... Should the icon always be utilities-terminal-symbolic? (or is there some weird way to apply -symbolic automagically, like in https://github.com/ddterm/gnome-shell-extension-ddterm/blob/master/ddterm/app/style.css )

@zleonov
Copy link

zleonov commented Jan 22, 2024

Hi @amezin, first just wanted to say what a cool extension. I use it often.

I came here to make a feature request and I see that it is already here.

  1. The default icon should always be utilities-terminal-symbolic, I manually change it in panelicon.js
  2. It should be configurable in the settings.

This look out of place:
ddterm-regular

This looks correct:
ddterm-symbolic

@amezin amezin added help wanted Extra attention is needed good first issue Good for newcomers labels Feb 13, 2024
@amezin
Copy link
Member

amezin commented Feb 13, 2024

https://github.com/GNOME/gnome-shell/blob/69ec2156bf068621eab3840e51fbf7f66227084d/data/theme/gnome-shell-sass/widgets/_panel.scss#L35 "symbolic" icon style can be applied with css, just like in Gtk.

It should be an option (checkbox) - because, for example, appindicator icons aren't "symbolic".

I'm not sure if the ability to override the icon name is actually necessary.

Anyway, there seems to be no tricky/non-trivial logic, pull requests are welcome.

@amezin amezin removed help wanted Extra attention is needed good first issue Good for newcomers labels Mar 10, 2024
@amezin amezin closed this as completed in 9ec1780 Mar 10, 2024
@amezin amezin changed the title Make panel icon configurable Make panel icon symbolic Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants