Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified to match latest Swift 3 syntax #39

Closed
wants to merge 1 commit into from

Conversation

Minitour
Copy link

@Minitour Minitour commented Aug 8, 2016

I modified the following (These were causing compilation issues):

in line 698:
Before:

for key in Array(parameters.keys).sorted(isOrderedBefore: <) {
            let value: AnyObject! = parameters[key]
            components += self.queryComponents(key, value)
}

After:

for key in Array(parameters.keys).sorted(by: <){
            let value: AnyObject! = parameters[key]
            components += self.queryComponents(key, value)
}

in line 739:
Before:

if let component = URL.lastPathComponent {
                    partFilename = component
}

After:

if let component:String = URL.lastPathComponent {
                    partFilename = component
}

@dduan
Copy link
Owner

dduan commented Aug 8, 2016

Thanks, @Minitour! Can you remove all the whitespace changes?

@Minitour
Copy link
Author

Minitour commented Aug 8, 2016

I copied and pasted the raw code into Xcode and modified it there. I will create another pull request later on where the file will be modified directly rather than copying and pasting it.
Let me know @dduan if you want me to do that, unless you will commit the changes I mentioned above in the conversation yourself in a future update.

@JustHTTP
Copy link
Collaborator

JustHTTP commented Aug 8, 2016

I'll make this library work with Swift 3 in the future, yes :)

Daniel Duan
Sent from my iPhone

On Aug 8, 2016, at 7:47 AM, Antonio Zaitoun notifications@github.com wrote:

I copied and pasted the raw code into Xcode and modified it there. I will create another pull request later on where the file will be modified directly rather than copying and pasting it.
Let me know @dduan if you want me to do that, unless you will commit the changes I mentioned above in the conversation yourself in a future update.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@dduan
Copy link
Owner

dduan commented Sep 11, 2016

Updated master to work with Xcode GM. Thank you!

@dduan dduan closed this Sep 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants