Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to angular 14 with some minor changes #173

Merged
merged 6 commits into from
Jul 3, 2022

Conversation

ddubrava
Copy link
Owner

@ddubrava ddubrava commented Jul 3, 2022

  1. Update to Angular 14
  2. Style changes: remove underscore for private variables, set up simple-import-sort plugin
  3. Replace subscription.add() with takeUntil(destroy$)
  4. Refactor usage of some RxJS operators
  5. Improve folder structure

@ddubrava ddubrava self-assigned this Jul 3, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2022

Codecov Report

Merging #173 (f0bf502) into master (ba36fd3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #173   +/-   ##
=======================================
  Coverage   99.51%   99.52%           
=======================================
  Files          13       14    +1     
  Lines         616      625    +9     
  Branches       89       83    -6     
=======================================
+ Hits          613      622    +9     
  Misses          3        3           
Impacted Files Coverage Δ
...-yandex-maps/src/lib/angular-yandex-maps.module.ts 100.00% <100.00%> (ø)
.../components/ya-clusterer/ya-clusterer.component.ts 97.50% <100.00%> (-0.04%) ⬇️
.../lib/components/ya-control/ya-control.directive.ts 100.00% <100.00%> (ø)
.../components/ya-geoobject/ya-geoobject.directive.ts 100.00% <100.00%> (ø)
...maps/src/lib/components/ya-map/ya-map.component.ts 100.00% <100.00%> (ø)
...omponents/ya-multiroute/ya-multiroute.directive.ts 100.00% <100.00%> (ø)
...s/ya-object-manager/ya-object-manager.directive.ts 100.00% <100.00%> (ø)
...ib/components/ya-panorama/ya-panorama.directive.ts 100.00% <100.00%> (ø)
.../components/ya-placemark/ya-placemark.directive.ts 100.00% <100.00%> (ø)
...yandex-maps/src/lib/event-manager/event-manager.ts 97.50% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba36fd3...f0bf502. Read the comment docs.

@ddubrava ddubrava merged commit 780efbe into master Jul 3, 2022
@ddubrava ddubrava deleted the update-to-angular-14 branch July 3, 2022 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants