Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move PLATFORM_ID logic from components to API loader service #175

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

ddubrava
Copy link
Owner

@ddubrava ddubrava commented Aug 16, 2022

Closes #174

@ddubrava ddubrava self-assigned this Aug 16, 2022
@ddubrava ddubrava force-pushed the fix-server-side-rendering branch 2 times, most recently from 75439f3 to 2181bef Compare August 16, 2022 17:58
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2022

Codecov Report

Base: 99.52% // Head: 99.51% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (b413835) compared to base (780efbe).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
- Coverage   99.52%   99.51%   -0.01%     
==========================================
  Files          14       14              
  Lines         625      618       -7     
  Branches       83       76       -7     
==========================================
- Hits          622      615       -7     
  Misses          3        3              
Impacted Files Coverage Δ
.../components/ya-clusterer/ya-clusterer.component.ts 97.46% <100.00%> (-0.04%) ⬇️
.../lib/components/ya-control/ya-control.directive.ts 100.00% <100.00%> (ø)
.../components/ya-geoobject/ya-geoobject.directive.ts 100.00% <100.00%> (ø)
...maps/src/lib/components/ya-map/ya-map.component.ts 100.00% <100.00%> (ø)
...omponents/ya-multiroute/ya-multiroute.directive.ts 100.00% <100.00%> (ø)
...s/ya-object-manager/ya-object-manager.directive.ts 100.00% <100.00%> (ø)
...ib/components/ya-panorama/ya-panorama.directive.ts 100.00% <100.00%> (ø)
.../components/ya-placemark/ya-placemark.directive.ts 100.00% <100.00%> (ø)
...ib/services/ya-api-loader/ya-api-loader.service.ts 100.00% <100.00%> (ø)

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ddubrava ddubrava changed the title fix: replace isPlatformBrowser logic with defaultView in loader service fix: move PLATFORM_ID logic from components to API loader service Aug 16, 2022
@ddubrava ddubrava merged commit 8d902c5 into master Aug 16, 2022
@ddubrava ddubrava deleted the fix-server-side-rendering branch August 16, 2022 20:39
@ddubrava ddubrava mentioned this pull request Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't build a project with SSR when using a YaApiLoaderService
2 participants