Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: throw error if API version is v3 #227

Merged
merged 1 commit into from Nov 18, 2023

Conversation

ddubrava
Copy link
Owner

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

No errors, if someone decides to pass 'v3' everything breaks.

What is the new behavior?

Now we provide an error that 'v3' is not supported.

Does this PR introduce a breaking change?

  • Yes
  • No

@ddubrava ddubrava self-assigned this Nov 18, 2023
Copy link

codecov bot commented Nov 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2376317) 98.47% compared to head (53e9408) 98.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #227   +/-   ##
=======================================
  Coverage   98.47%   98.47%           
=======================================
  Files          14       14           
  Lines         655      657    +2     
  Branches       71       72    +1     
=======================================
+ Hits          645      647    +2     
  Misses          4        4           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ddubrava ddubrava merged commit f4c199a into master Nov 18, 2023
6 checks passed
@ddubrava ddubrava deleted the throw-error-if-version-is-v3 branch November 18, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant