Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roman Numeral Notation #10

Open
kevinhongw opened this issue Apr 17, 2019 · 4 comments
Open

Roman Numeral Notation #10

kevinhongw opened this issue Apr 17, 2019 · 4 comments

Comments

@kevinhongw
Copy link

It would be nice to have a function to output the roman numeral notation of the chords. A lot of musicians I worked with prefer numeral notation. I could try to create a PR when I have time.

@MikeMijnheer
Copy link

I'm interested in this too! Did you implement it already by any chance @KevinHong913?

@OskarsPakers
Copy link

How would you expect the API to be?
Conversion to Roman notation would not be a transposition so .transpose() method would not make sense, right?
Or would something like this make sense?

 Transposer.transpose(
"G        C           Am7            C        D7       G" +
"Saying I love you is not the words I want to hear from you").toNumericNotation().toString()
'V       I          vi7            I       II7       V' +
'Saying I love you is not the words I want to hear from you'

@contributor
Copy link

contributor commented Oct 21, 2022

I would call the method toRomanNumerals() @OskarsPakers your example correctly converts to roman numerals. If can be more tricky to convert non-diatonic chords, for example Bb is common to the key of C - it would be VIIb. I don't recall ever seeing sharps in roman numerals notation, only flats (but I'm not musician)

image

@contributor
Copy link

The hardest thing could be chord inversions (slash chords). Notation quite complex, for the first version we could just throw not implemented error

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants