Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ff libraries in develop are unchecked/untested (and likely problematic) #5

Open
matteoaldeghi opened this issue Apr 12, 2018 · 1 comment
Labels
develop_branch issue specific to the develop branch

Comments

@matteoaldeghi
Copy link
Member

These ff libraries come from merging master (dna ff) and proline branches (protein ff), and then merging dna and protein forcefields so that they are in a single folder. It is likely the resulting libraries might be broken in some way or another. I have been using bits and pieces (either only protein, dna, or rna) of the amber forcefields for testing of refactored code, which seemed fine, but at some point for any real usage we should re-build the libraries from scratch, maybe after having implemented some automated energy tests/checks.

@matteoaldeghi matteoaldeghi added the develop_branch issue specific to the develop branch label Apr 12, 2018
@bisdan
Copy link

bisdan commented Nov 26, 2023

Hello,

could we please get an update on this? Is it ok to use the force fields in develop for simulations involving only proteins? For example, "charmm36m-mut" does not seem to present in master (for proteins). On the other hand, if py3/Icolos support is required, one is directly forwarded to the develop branch.

Thanks in advance

I just noticed that you perform a few pytests in the develop branch which seem to pass. Here you specifically test "amber99sb-star-ildn-mut". Can this issue/warning be closed then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
develop_branch issue specific to the develop branch
Projects
None yet
Development

No branches or pull requests

2 participants