Revert also down to meta 1.8.0?

[monsieurtanuki]

Because every version of flutter_test from sdk depends on meta 1.8.0 and crop_image >=1.0.8 depends on meta ^1.9.1, flutter_test from sdk is incompatible with crop_image >=1.0.8.

[deakjahn]

I don't normally use meta for anything, so I don't know immediately where it was introduced at all. Maybe one of your PRs? :-) I would suggest to remove it altogether.

[deakjahn]

1. I don't think that image setter hurts anybody.

2. Same about the two rectangle helper functions. If you really want to hide them, my usual solution is just to make the extension name private in the same source file, eg. _RectExtensions. That's completely enough to hide it from the outside, although I don't think that it harms anything even if exposed.

[monsieurtanuki]

@deakjahn You added meta at least 2 years ago:

As I come from Java, I do think it's much cleaner to use meta annotations, without having to play with file names, class names or method names.

[deakjahn]

Really? I wonder why... Now as I check it, it was in the dev dependencies part, only got moved up. Still doesn't answer why it was needed in the first place. :-) Yep, it was down there in the initial commit. I probably cloned another package to start this one, that's why.

Anyway, I'll remove it now. I only partly agree with you in this, namely, if it's an annotation that's part of the core language itself, then OK. But not to rely on an outside package just to do something that's not even necessary... And, after all, the underscore is Dart's own mechanism for visibility, not a hack but part of the language itself... :-)