Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with Knockout containerless control flow syntax #23

Closed
mikilion opened this issue Apr 6, 2016 · 4 comments
Closed

Problem with Knockout containerless control flow syntax #23

mikilion opened this issue Apr 6, 2016 · 4 comments
Assignees
Milestone

Comments

@mikilion
Copy link

mikilion commented Apr 6, 2016

The "Knockout" containerless control flow syntax should not be removed from the page.

<!-- ko if: someExpressionGoesHere -->
    <li>I want to make this item present/absent dynamically</li>
<!-- /ko -->

@deanhume deanhume self-assigned this Apr 6, 2016
@deanhume
Copy link
Owner

deanhume commented Apr 6, 2016

@mikilion - I'm thinking about the best way to work around this as there may be other JavaScript tools that require similar style comments. I am thinking of adding an ignoreHtmlComments flag - would this work for your issue?

@mikilion
Copy link
Author

mikilion commented Apr 7, 2016

@deanhume - Ignoring custom comments option by regular expression is a good idea.

@deanhume deanhume added this to the Release 1.8 milestone Apr 8, 2016
@deanhume
Copy link
Owner

This has been fixed with the latest commit and will go out as part of Release 1.8

@mikilion
Copy link
Author

mikilion commented Mar 30, 2017

The "ignoreknockoutcomments" argument doesn't work on 1.9 version.
I tried to modify following regular expression:
<!--(?!\[)(?!ko .*)(?!\/ko)(.*?)-->
to this:
<!--(?!ko .*)(?!\/ko)-->
at line 164 of the class "StreamReaderExtension".

Awaiting your feed back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants