Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsidian Integration #125

Open
deathau opened this issue Feb 14, 2022 · 11 comments
Open

Obsidian Integration #125

deathau opened this issue Feb 14, 2022 · 11 comments
Labels
enhancement New feature or request

Comments

@deathau
Copy link
Owner

deathau commented Feb 14, 2022

Integrate better with Obsidian

@deathau @skillhacker-code @00dani
https://github.com/jplattel/obsidian-clipper
This clipper can directly open obsidian and save the webpage to the previously designated folder.

Originally posted by @ajmz in #114 (comment)

@deathau deathau added the enhancement New feature or request label Feb 14, 2022
@deathau
Copy link
Owner Author

deathau commented Feb 14, 2022

I've split out Obsidian integration as its own issue.
I have a basic version working on the obsidian_integration branch based off a similar concept to the obsidian-clipper by @jplattel

Unfortunately, clipping articles and passing the contents via a URI has some serious limitations. Through some experimentation, I found that the URI was limited to just over 30,000 characters (using Firefox in Windows), which is not too bad, and I have a workaround for long articles: If the URI ends up too long, warn the user, copy the markdown to the clipboard, then create a new empty note for the user to paste in the markdown. It's not ideal, but it's only a problem for really long articles...

... or so I thought. It seems like Chrome has a much stricter limit on URIs, more in the ballpark of 2,000 characters, which isn't even enough for some short Wikipedia articles.

@deathau
Copy link
Owner Author

deathau commented Feb 14, 2022

I have a couple of ideas on how to overcome this with an Obsidian plugin that works in tandem with MarkDownload:

  1. An Obsidian plugin that provides all the same functionality as MarkDownload if passed a URL. This would mean you wouldn't even have to use the browser extension: just copy and paste the URL into the plugin in Obsidian. The extension would conveniently just pass the URL to the plugin, so there's less manual steps.
    Drawbacks: I'll have to maintain both the plugin and the extension with similar code. Also, you'd have similar configuration in Obsidian as MarkDownload, so the user would configure things in two places as well...
  2. A plugin which basically duplicates the obsidian://new functionality, but pastes in content from the clipboard after the file is created/opened.
  3. A plugin which can be passed file paths, and it moves those files into your vault. The extension would download as normal, then tell Obsidian to grab those files and move them. Not sure of the technical feasibility yet, it's just an idea.

@davidmarble
Copy link

Your first idea would seem to be the best (or only?) option for full functionality on mobile devices.

@aancw
Copy link

aancw commented Aug 21, 2022

Still work in progress for Obsidian integration. It bypass limitation of character in protocol URI. @davidmarble @deathau

  • Send selection to New file in obsidian
  • Send tab to new file in obsidian

Screen Shot 2022-08-21 at 17 32 40

@aancw aancw mentioned this issue Aug 21, 2022
2 tasks
@manan-gup
Copy link

Has anyone tested this on Linux? I can't get it to work. Right now I've just symlinked a folder from Downloads into my Obsidian vault and that's working fine.

@abbourne
Copy link

abbourne commented Mar 1, 2023

I'm finding the plugin works great except for Obsidian Integration. The context menu items for Obsidian don't show up on the menu, even though I have the "Enable Cotext Menus" and "Enable Obsidian Integration" checked. Using Version 110.0.5481.177 (Official Build) (arm64) on a MacBook M1 Air.

Having said that... I've tried 3 different web clipper plugins, and this is by far the best! I can't Obsidian Clipper to do anything at all!

Jeez! Human error! I figured it out. I was using the menu on the icon in the extensions bar. I learned I needed to right-click in the tab and use the tabs' context menu. It's all good, and the extension is great!

@aancw
Copy link

aancw commented Mar 2, 2023

@abbourne That's the problem for the obsidian context menu. After you click the "Enable Obsidian Integration", reload the plugin or just simply close the browser and open it again. Until now, that's the workaround I can say.

@abbourne
Copy link

abbourne commented Mar 2, 2023

In my case, it's just "human error". I did restart the browser - my problem was simply not knowing where to look for the menu item!
The plugin works great! That's for your work in developing and supporting it.

@aancw
Copy link

aancw commented Mar 2, 2023

@abbourne I'm glad to hear that

@justyns
Copy link

justyns commented Jun 29, 2023

Thanks for working on this!

Could we add a button to the window opened by the toolbar button to send to obsidian as well? Right now I think(?) the only way you can trigger saving to obsidian is by rightclicking and using that context menu. I click on the toolbar icon a lot too though and it'd be nice to either have the Download button send to obsidian, or even just a second button for sending directly to obsidian instead of downloading.

@Kmfernan5
Copy link

Kmfernan5 commented Oct 17, 2023

Thanks for working on this!

Could we add a button to the window opened by the toolbar button to send to obsidian as well? Right now I think(?) the only way you can trigger saving to obsidian is by rightclicking and using that context menu. I click on the toolbar icon a lot too though and it'd be nice to either have the Download button send to obsidian, or even just a second button for sending directly to obsidian instead of downloading.

Yes! Please! Having to right click then move mouse everytime is killing me.
Is there a way to use a keyboard shortcut for this?

https://share.zight.com/X6unAbNw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants