Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBZ-4471 Introducing Debezium Server Example with MySQL and GCP PubSub #334

Conversation

ilyasahsan123
Copy link
Contributor

@@ -0,0 +1,12 @@
debezium.sink.type=pubsub
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try to run it? Does it really work without internal schema history configured?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edited. I also tested the connector with the result event was successfully sent to Pubsub.

@jpechane
Copy link
Contributor

@ilyasahsan123 Thanks for the PR, could you please remove the brackets around DBZ-4471 in commit messages?

@ilyasahsan123 ilyasahsan123 changed the title [DBZ-4471] Adding Debezium Server example using MySQL and GCP PubSub DBZ-4471 Adding Debezium Server example using MySQL and GCP PubSub Sep 27, 2023
@ilyasahsan123 ilyasahsan123 force-pushed the DBZ-4471-debezium-server-sink-pubsub-examples branch 6 times, most recently from 7583715 to c602be2 Compare September 27, 2023 14:16
@ilyasahsan123 ilyasahsan123 changed the title DBZ-4471 Adding Debezium Server example using MySQL and GCP PubSub DBZ-4471 Introducing Debezium Server Example with MySQL and GCP PubSub Sep 27, 2023
@ilyasahsan123 ilyasahsan123 force-pushed the DBZ-4471-debezium-server-sink-pubsub-examples branch from c602be2 to c791233 Compare September 27, 2023 14:20
@ilyasahsan123
Copy link
Contributor Author

@ilyasahsan123 Thanks for the PR, could you please remove the brackets around DBZ-4471 in commit messages?

Sure. edited.

@ilyasahsan123 ilyasahsan123 force-pushed the DBZ-4471-debezium-server-sink-pubsub-examples branch 4 times, most recently from 7699d6f to 40aab2b Compare September 27, 2023 15:42
@ilyasahsan123 ilyasahsan123 force-pushed the DBZ-4471-debezium-server-sink-pubsub-examples branch from 40aab2b to c16d1bf Compare September 27, 2023 15:44
@ilyasahsan123 ilyasahsan123 reopened this Sep 27, 2023
Copy link
Contributor

@jpechane jpechane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilyasahsan123 Thanks a lot. IMHO we are almost done. There is just one remaining issue in MongoDB documentation.

```


### MongoDB Debezium Connector
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at original MongoDB documentation. The setup sequence is different from MySQL or Postgres. Also this text speaks about database and table which is not correct in context of MongoDB.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your feedback,@jpechane. Could you please re-review this?

@jpechane jpechane merged commit df0ab89 into debezium:main Oct 4, 2023
@jpechane
Copy link
Contributor

jpechane commented Oct 4, 2023

@ilyasahsan123 Applied, thanks a lot

@ilyasahsan123 ilyasahsan123 deleted the DBZ-4471-debezium-server-sink-pubsub-examples branch October 5, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants