Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBZ-5930: Add the doc for vitess snapshot.mode #4158

Merged
merged 8 commits into from Jan 17, 2023

Conversation

yoheimuta
Copy link
Contributor

Vitess connector finally supports the snapshot feature.
And the snapshot.mode specifies the criteria for performing a snapshot when the connector starts.

@yoheimuta
Copy link
Contributor Author

@jpechane I prepared the docs PR!

@jpechane
Copy link
Contributor

jpechane commented Jan 5, 2023

@roldanbob This is community only feature. Could you please check the text and sanitize/change if needed? Thanks a lot

documentation/modules/ROOT/pages/connectors/vitess.adoc Outdated Show resolved Hide resolved
documentation/modules/ROOT/pages/connectors/vitess.adoc Outdated Show resolved Hide resolved
documentation/modules/ROOT/pages/connectors/vitess.adoc Outdated Show resolved Hide resolved
documentation/modules/ROOT/pages/connectors/vitess.adoc Outdated Show resolved Hide resolved
documentation/modules/ROOT/pages/connectors/vitess.adoc Outdated Show resolved Hide resolved
[NOTE]
====
In Vitess 15 or earlier, it is not possible to resume `VStream Copy.`
Starting in Vitess 16, it will support resuming this initial copy phase if it's interrupted for any reason.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Starting in Vitess 16, it will support resuming this initial copy phase if it's interrupted for any reason.
Beginning with Vitess 16, you can resume the initial copy phase if it's interrupted for any reason.

It's not clear from the original text, but with Vitess 16 and later, is the initial copy phase resumed automatically following an interruption?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoheimuta Could you please comment on that question? Thanks a lot.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your reviews!

with Vitess 16 and later, is the initial copy phase resumed automatically following an interruption?

@roldanbob No. In order to achieve this, the connector will also need to be updated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your reviews!

You're very welcome!

with Vitess 16 and later, is the initial copy phase resumed automatically following an interruption?

@roldanbob No. In order to achieve this, the connector will also need to be updated.

I'm not sure that I follow. Do you mean that:

  1. You must restart the connector to resume a snapshot that was interrupted?
  2. You must update the Debezium Vitess connector to the version that this change is applied to (2.1?)?
  3. Or is it actually both?: That is, if you're running earlier versions of the connector against Vitess 16 or later, you cannot resume a snapshot that was interrupted. You must be running 2.1 or later and restart the connector to resume an interrupted snapshot.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roldanbob 2 is correct!

Users will need to update both the Debezium Vitess connector to version 2.1? and Vitess to a version greater than or equal to 16 in order for the feature (automatic retry) to work correctly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It means the release of Vitess 16 is a blocker for me to implement this feature fault torelantly.

@github-actions
Copy link

Hi @yoheimuta, thanks for your contribution. Please prefix the commit message(s) with the DBZ-xxx JIRA issue key.

@github-actions
Copy link

Hi @yoheimuta, thanks for your contribution. Please prefix the commit message(s) with the DBZ-xxx JIRA issue key.

@yoheimuta
Copy link
Contributor Author

@jpechane Is something missing in my commit 5da7d4a?
Could you please help me understand how to fix Commit message format check?

@jpechane jpechane merged commit 0f01851 into debezium:main Jan 17, 2023
@jpechane
Copy link
Contributor

Applied, thanks guys!

@yoheimuta There was no issue in that one commit. I just fixed commit message in all commits in this PR.

@yoheimuta yoheimuta deleted the DBZ-5930_docs branch January 17, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants