Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Remove setTimeOut from steps #97

Open
twjasa opened this issue Nov 23, 2022 · 0 comments
Open

[Feature Request] Remove setTimeOut from steps #97

twjasa opened this issue Nov 23, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@twjasa
Copy link

twjasa commented Nov 23, 2022

Hello,

amazing project!! 馃檶 I want to create a feature that can show to the user what is the best set available for the image selected, how many sets needed and which is the cheapest.

Is your feature request related to a problem? If so, please describe it.
To create an algorithm to do that I had to fix the problem where the steps were before a setTimeOut, so here it is :)

Describe the solution you'd like
I used the method ready() of the lib cropperjs to detect when the input is finally loaded, then create a flag to run (or not) run step1. then remove all setTimeOut.

Here is the PR

#96

@twjasa twjasa added the enhancement New feature or request label Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants