Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Textfield does not dispatch internal messages when user messages are installed #333

Closed
aforemny opened this issue Jun 30, 2017 · 3 comments
Assignees
Milestone

Comments

@aforemny
Copy link
Collaborator

I think this is the root cause of some Textfield issues, as mentioned in some of their comments. I've come up with a fix in 6feddc4. I have some second thoughts about the code and will leave this open for a while. Feedback appreciated.

@aforemny
Copy link
Collaborator Author

aforemny commented Jun 30, 2017

@vipentti With regards to #164, is commit 6feddc4 the way to go? Does that mean we do not need to have the focusin/focusout polyfill anymore?

@aforemny
Copy link
Collaborator Author

I think this is the way to go. For now, only Textfield uses this, see #338. I also removed the focusin/out polyfill as I think it is not needed anymore (27467d5).

@dcbb
Copy link

dcbb commented Nov 8, 2017

When will the fix to the labels not disappearing in Textfields shipped? I installed elm-mdl 8.1 with elm-package and I have the issue, but the here it's closed. Or am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants