Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for ThreeTenBp #8

Open
masc3d opened this issue Feb 6, 2019 · 3 comments
Open

Support for ThreeTenBp #8

masc3d opened this issue Feb 6, 2019 · 3 comments

Comments

@masc3d
Copy link

masc3d commented Feb 6, 2019

relating to #7, would it make sense to also add support for https://github.com/ThreeTen/threetenbp?

It can be used as a drop-in replacement for android < API Level 26, allowing very smooth (package replace) migration once a project moves to >= 26.

Would you accept PR for this?
@debop
Copy link
Owner

debop commented Feb 17, 2019

Sure, please PR

@masc3d
Copy link
Author

masc3d commented May 9, 2019

would you agree to improve packages for major future release? eg

com.github.debop.koda.time -> standard java.time
com.github.debop.koda.joda -> joda
com.github.debop.koda.threetenbp

@debop
Copy link
Owner

debop commented Jun 8, 2019

Split module

java-time ( for standard java.time in jdk 8)
koda-time for joda

You can add threetenbp module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@debop @masc3d