Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeoPDF Export - step forward using Time Controller interval #4992

Open
IanMayo opened this issue Oct 1, 2020 · 6 comments · Fixed by #4994 · May be fixed by #5005
Open

GeoPDF Export - step forward using Time Controller interval #4992

IanMayo opened this issue Oct 1, 2020 · 6 comments · Fixed by #4994 · May be fixed by #5005
Assignees

Comments

@IanMayo
Copy link
Member

IanMayo commented Oct 1, 2020

When the user Plays a GeoPDF we control the time interval between each step forward (probably a second).

We should instead take this value from the TimeController Step Interval property.

Then Play can be faster or slower than one second.

@IanMayo IanMayo changed the title GeoPDF - step forward using Time Controller interval GeoPDF Export - step forward using Time Controller interval Oct 1, 2020
@helenayele
Copy link
Collaborator

@IanMayo/ @saulhidalgoaular , after I generate the track into GeoPDF what could I play the pdf file and test this issue?

@helenayele
Copy link
Collaborator

We are now taking the time interval from small step property rather than Step Interval, right ?
Image from Gyazo
here is the step property:
Image from Gyazo

@IanMayo
Copy link
Member Author

IanMayo commented Oct 5, 2020

@helenayele = there are two intervals:

  1. The pause in real-time between each step forwards for the animated replay (step interval in Debrief)
  2. How far the time-label moves forward each step (Small step in Debrief)

@helenayele
Copy link
Collaborator

Okay clear thanks!
One more thing I see an issue is, it exports invisible positions that are invisible in debrief.
See the below screenshots:
In full debrief I filtered to some time period so that I want to see only those selected positions:
Image from Gyazo

And I exported it to GeoPDF file and looks like:
Image from Gyazo
See that it shows all the positions of the track.
Is this by design?

@IanMayo
Copy link
Member Author

IanMayo commented Oct 5, 2020

No, it should only export visible positions. That's one for @saulhidalgoaular .

@IanMayo IanMayo reopened this Oct 5, 2020
@helenayele
Copy link
Collaborator

Okay @IanMayo thanks.
@saulhidalgoaular , one more thing to correct is the end time shown on the pdf file.
if we see the above example, small step = 5 min as example , and if the tracks end time = 121141, the track ends playing in GeoPDF file on 121140 not on 121141.
Image from Gyazo

@saulhidalgoaular saulhidalgoaular linked a pull request Oct 9, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants