-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create platform icons for dashboard - plus nice fallback #936
Comments
The platform-types they're using have matured. I'll get a copy, and update |
Here is the up-to-date list of platform types:
|
Working with client to refine platform-types list, before we update icons |
Updated set of platform types attached |
Aah @robintw , we need to make some code changes to reflect these updates. The |
Aah, we also need to update the |
@IanMayo Does the PR that closed this issue include a fallback icon for an unknown platform type? I couldn't see it in that PR's code, but it might have already been implemented elsewhere. |
Thanks for chasing that up @robintw . No, it's my preference to use the "missing icon" image as a prompt to get the analysts to specify a Platform-Type for the platform in Pepys-Admin. |
馃悶 Overview
The dashboard displays an icon for each platform. When I started using the dashboard today, it couldn't find the relevant icon for the platform type (
Tug
), so it displayed an error. I temporarily fixed this by forcing all icons to be the one that is currently present (calledWarship.svg
).We should create an icon for each of the default platform types (listed below), plus alter the code to use a fallback icon (a ? maybe...) if it can't find an icon.
The icons for these need to be in SVG format, and be placed in
pepys_timeline/static/image
with exactly the same names as the platform types listed above - egNaval - submarine.svg
.馃敆 Feature
#602
馃敘 Acceptance criteria
Correct icons display in the dashboard, even when a platform type without an icon is used.
The text was updated successfully, but these errors were encountered: