Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create platform icons for dashboard - plus nice fallback #936

Closed
robintw opened this issue Aug 12, 2021 · 8 comments 路 Fixed by #1083
Closed

Create platform icons for dashboard - plus nice fallback #936

robintw opened this issue Aug 12, 2021 · 8 comments 路 Fixed by #1083
Assignees
Labels
CF_Backlog Low priority backlog items dashboard Issues related to dashboard / timeline Task Package of work V-High High value
Projects

Comments

@robintw
Copy link
Collaborator

robintw commented Aug 12, 2021

馃悶 Overview

The dashboard displays an icon for each platform. When I started using the dashboard today, it couldn't find the relevant icon for the platform type (Tug), so it displayed an error. I temporarily fixed this by forcing all icons to be the one that is currently present (called Warship.svg).

We should create an icon for each of the default platform types (listed below), plus alter the code to use a fallback icon (a ? maybe...) if it can't find an icon.

Naval - aircraft
Naval - frigate
Naval - auxiliary
Naval - destroyer
Naval - survey
Naval - minesweeper
Naval - patrol
Naval - aircraft carrier
Naval - submarine
Naval - miscellaneous
Merchant
Tug
Tanker
Law Enforcement
Pleasure Craft
Search and Rescue
Fishing Vessel
Passenger/Ferry
High Speed Craft

The icons for these need to be in SVG format, and be placed in pepys_timeline/static/image with exactly the same names as the platform types listed above - eg Naval - submarine.svg.

馃敆 Feature

#602

馃敘 Acceptance criteria

Correct icons display in the dashboard, even when a platform type without an icon is used.

@robintw robintw added the Task Package of work label Aug 12, 2021
@IanMayo IanMayo added A43_candidate V-High High value CF_Backlog Low priority backlog items dashboard Issues related to dashboard / timeline and removed A43_candidate labels Aug 12, 2021
@IanMayo IanMayo added this to To do in AS43 Tasks Aug 13, 2021
@IanMayo
Copy link
Member

IanMayo commented Aug 16, 2021

The platform-types they're using have matured. I'll get a copy, and update tracstor with it. We can use that for our icon shopping list.

@IanMayo
Copy link
Member

IanMayo commented Aug 16, 2021

Here is the up-to-date list of platform types:

Attack_Craft
Fishing聽Vessel
High聽Speed聽Craft
Law聽Enforcement
Medical
Merchant
Naval聽-聽aircraft聽carrier
Naval聽-聽amphib
Naval聽-聽auxiliary
Naval聽-聽destroyer
Naval聽-聽ExCon
Naval聽-聽fixed聽wing
Naval聽-聽frigate
Naval聽-聽minesweeper
Naval聽-聽miscellaneous
Naval聽-聽patrol
Naval聽-聽rotary聽wing
Naval聽-聽submarine
Naval聽-聽survey
Naval/Military
Passenger/Ferry
Pleasure聽Craft
Search聽and聽Rescue
Tanker
Tug

@IanMayo
Copy link
Member

IanMayo commented Aug 26, 2021

Working with client to refine platform-types list, before we update icons

@IanMayo IanMayo moved this from To do to In progress in AS43 Tasks Aug 26, 2021
@IanMayo
Copy link
Member

IanMayo commented Oct 28, 2021

Updated set of platform types attached
Revised Platforms for Pepys.xlsx
.

@IanMayo
Copy link
Member

IanMayo commented Nov 11, 2021

Aah @robintw , we need to make some code changes to reflect these updates.

The defaults-resolver should use Naval - frigate rather than Warship.
Where we use Warship in unit tests we should also switch to Naval - frigate.

@IanMayo
Copy link
Member

IanMayo commented Nov 11, 2021

Aah, we also need to update the PlatformTypes in platform_types.csv. I'll do that.

AS43 Tasks automation moved this from In progress to Done Nov 15, 2021
@robintw
Copy link
Collaborator Author

robintw commented Nov 15, 2021

@IanMayo Does the PR that closed this issue include a fallback icon for an unknown platform type? I couldn't see it in that PR's code, but it might have already been implemented elsewhere.

@IanMayo
Copy link
Member

IanMayo commented Nov 16, 2021

Thanks for chasing that up @robintw . No, it's my preference to use the "missing icon" image as a prompt to get the analysts to specify a Platform-Type for the platform in Pepys-Admin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CF_Backlog Low priority backlog items dashboard Issues related to dashboard / timeline Task Package of work V-High High value
Projects
AS43 Tasks
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants