Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include supports-color as dependency #612

Closed
Qix- opened this issue Sep 14, 2018 · 3 comments
Closed

Include supports-color as dependency #612

Qix- opened this issue Sep 14, 2018 · 3 comments
Labels
change-minor This proposes or provides a change that requires a minor release discussion This issue is requesting comments and discussion

Comments

@Qix-
Copy link
Member

Qix- commented Sep 14, 2018

Right now, we enable 256 colors if you have supports-color as a dependency. A few individuals have mentioned it should be included in the project dependencies, which sounds ideal.

The reason why we didn't (initially) do so is because we didn't want a minor/patch bump to introduce yet another dependency.

Thoughts?

@Qix- Qix- added discussion This issue is requesting comments and discussion change-minor This proposes or provides a change that requires a minor release labels Sep 14, 2018
@Jezorko
Copy link

Jezorko commented Oct 22, 2018

I think it's better to give users a choice. Not everyone needs fancy colors. Also, how to add them is well explained in the README.

@Qix-
Copy link
Member Author

Qix- commented Oct 22, 2018

@Jezorko Yeah I'm back and forth, but I mostly agree. A few times, though, people have complained about it - hence this ticket.

@Qix-
Copy link
Member Author

Qix- commented Dec 19, 2018

I think there's going to be a better solution coming around the corner with #556, allowing users to opt-in to more colors. I want to get some more feedback from a few others regarding how that will work, but I think debug is already too big for what it does and adding supports-color will only exasperate the issue.

Closing in lieu of #556 (which indirectly solves this).

Thanks for the input @Jezorko.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change-minor This proposes or provides a change that requires a minor release discussion This issue is requesting comments and discussion
Development

No branches or pull requests

2 participants