Is.number missing union with null

[Honga1]

Hey :) I saw your lib on reddit. I was just reading the source and saw this:

as-is/is/index.ts

Line 18 in c35e237

public static number(value: unknown, allowNull = false): value is number {

Shouldn't you return number | null if it is allowed to be null?

[dec-land]

You're right! I'll actually remove the allowNull checks, they were specific to my project in which I was filtering out properties from an object unless they were the correct type. But if they were null I wanted them to remain.

I should really enable strict mode too in the tsconfig which would have reported a warning here, it was disabled in the legacy projects i've been working on which I created as-is for. Good spot 👍

[dec-land]

Issue closed, allowNull has been removed as stated above. Ty :)