Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New exceptions from 0.47 are not exported in __all__ #160

Open
TheElementalOfDestruction opened this issue Dec 4, 2023 · 1 comment
Open

New exceptions from 0.47 are not exported in __all__ #160

TheElementalOfDestruction opened this issue Dec 4, 2023 · 1 comment
Assignees
@decalage2
Labels
bug
Milestone
olefile 0.47

Comments

@TheElementalOfDestruction
Copy link
Contributor

Not sure if this was intended or not (or whether this would qualify as a bug), but the new exceptions OleFileError and NotOleFileError are not listed in the __all__ attribute of olefile.py. As such, they are not part of the top level module and require a user to fetch them directly from olefile.olefile.
@decalage2 decalage2 self-assigned this Dec 4, 2023
@decalage2
Copy link
Owner

Good catch, thanks!

@decalage2 decalage2 added the bug label Dec 4, 2023
@decalage2 decalage2 added this to the olefile 0.47 milestone Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@decalage2 decalage2

Labels
bug
Projects
None yet
Milestone
olefile 0.47
Development

No branches or pull requests
2 participants
@decalage2 @TheElementalOfDestruction