Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] OleFileIO.getproperties creates immense for-loop #162

Open
andrew0411 opened this issue Jan 3, 2024 · 3 comments
Open

[bug] OleFileIO.getproperties creates immense for-loop #162

andrew0411 opened this issue Jan 3, 2024 · 3 comments
Labels
Milestone

Comments

@andrew0411
Copy link

andrew0411 commented Jan 3, 2024

getproperties function creates massive property_type (ex.4294967295) that derives from unpacking '\xff\xff\xff\xff'.

image
The picture depicts s, offset, property_id, property_type, which are the inputs of OleFileIO._parse_property() respectively.

The for-loop with 4294967295 iteraions are made in OleFileIO._parse_property() which occurs system and resource instability.

Also, the bug in getproperties causes lots of function fail in the oletools as well.

@andrew0411
Copy link
Author

To add, the last version of olefile (v0.46) has returned None for all properties in the same file. I think the if-else syntax in the latest getproperties needs to be fixed.

@decalage2 decalage2 added the bug label Jan 8, 2024
@decalage2 decalage2 added this to the olefile 0.47 milestone Jan 8, 2024
@decalage2
Copy link
Owner

Hello, thanks for reporting the bug. Could you please share a sample file that triggers the issue?

@andrew0411
Copy link
Author

Apologies for the delayed response. Please see the attachments that you requested.
sample.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants