New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Backend o-auth permissions set too widely #1423
Comments
I suppose making this configurable would be fine, just might require some error handling around attempts to access restricted repos. Proposing:
Thoughts? |
@erquhart The screen capture implies the login has access to ALL repos within the login. Is that true or is it only the repo logging into? |
@talves It has access to every repo on your account -- the only two OAuth scopes available for repo access are |
The permissions are insane. I don't need Netlify to have read/write permissions over ALL repo's and I don't need Netlify to have organization access. What for does Netlify need this? Plus, the default setting is that it wants PUBLIC and PRIVATE repo access? Seriously, this is red flags all over for me and it's making me not want to use Netlify. |
See the comment before yours:
That's GitHub's decision, not Netlify's. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I'm going to prioritize this one to better support the open authoring workflow (no need for private repository access) |
Currently when using Github Backend, the app requires access to pretty much everything.
The scope is hard coded to
repo
here : https://github.com/netlify/netlify-cms/blob/78e4b829d0ced72f8f38721d38c0d67ccb092aaf/src/backends/github/AuthenticationPage.js#L26It would make more sense to have a much more limited scope or at least a way to customise it.
I'd suggest
public_repo
by default.In the future, maybe deploy keys would work better, allowing only access to a single repo.
The text was updated successfully, but these errors were encountered: