Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for transliteration of German "umlaute" in slugs #1685

Open
erikhofer opened this issue Aug 28, 2018 · 4 comments
Open

Add support for transliteration of German "umlaute" in slugs #1685

erikhofer opened this issue Aug 28, 2018 · 4 comments
Labels

Comments

@erikhofer
Copy link

erikhofer commented Aug 28, 2018

Is your feature request related to a problem? Please describe.
If the title contains a German umlaut (äöü) and use clean_accents: true, they are converted to plain letters aou. While this is suitable for actual accents (e.g. é), it looks really odd for umlaute.

Describe the solution you'd like
In German there is an official rule for transliterating special characters:

ä -> ae
ö -> oe
ü -> ue
ß -> ss

The last rule is already covered by clean_accents: true. It would be nice to change the conversion of the remaining characters or provide an additional setting to enable it.

Describe alternatives you've considered
Manually editing the file name is possible but inconvenient. The ability to edit slugs as discussed in #445 would make this less of an issue.

Additional context
N/A

@tech4him1
Copy link
Contributor

tech4him1 commented Aug 28, 2018

We use a package -- https://github.com/andrewrk/node-diacritics -- to strip accents, so that is probably the best place to submit changes. If you have a better alternative or option, though, we can discuss here.

@stale
Copy link

stale bot commented Oct 29, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status: stale label Oct 29, 2019
@CanRau
Copy link

CanRau commented Dec 30, 2019

One way might be to handle those before stripping diacritics

@luksak
Copy link

luksak commented Jan 6, 2022

I'd love to see this solved. There is an issue for this against node-diacritics: andrewrk/node-diacritics#35

While researching, I realized that we are using a not well-maintained (latest commit is from 2017) and not that popular package. There are others that support German umlauts, have much more recent commits are a lot more popular:

I'd suggest switching to a package to has better transliteration support and is well maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants