Add map widget #2051
Merged
Add map widget #2051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview proposed changes to netlifycms.org in the link below: Built with commit a73484f |
|
Preview proposed changes to the CMS demo site in the link below: Built with commit a73484f |
erquhart
suggested changes
Feb 5, 2019
There was a problem hiding this comment.
@friedjoff this is a fantastic PR, thank you! A couple of very small change requests here for publishing, we can merge after that.
| 1. Check out the [main readme](https://github.com/netlify/netlify-cms/#readme) or the [documentation | ||
| site](https://www.netlifycms.org) for more info. | ||
| 2. Reach out to the [community chat](https://gitter.im/netlify/netlifycms/) if you need help. | ||
| 3. Help out and [write the readme yourself](https://github.com/netlify/netlify-cms/edit/master/packages/netlify-cms-widget-list/README.md)! |
There was a problem hiding this comment.
Replace netlify-cms-widget-list with netlify-cms-widget-map
| { | ||
| "name": "netlify-cms-widget-map", | ||
| "description": "Widget for editing spatial data in Netlify CMS.", | ||
| "version": "2.0.0", |
There was a problem hiding this comment.
New packages can start at 1.0.0
|
@erquhart thanks for reviewing, glad you like it! I've fixed both issues. |
erquhart
approved these changes
Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds a map widget to edit spatial data in Netlify CMS. See #434 for more information about possible use cases. The map widget is using the OpenLayers JavaScript library and map tiles from OpenStreetMap. Currently the widget is limited to the most important features. Custom map widgets for special use cases can reuse the
withMapControl()HOC.Closes #434.
Test plan
The map widget has been added to the kitchen sink collection and should look similiar to the following screenshot:
