Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(backend-gitlab): add GraphQL support #6034

Open
erezrokah opened this issue Dec 7, 2021 · 11 comments
Open

feature(backend-gitlab): add GraphQL support #6034

erezrokah opened this issue Dec 7, 2021 · 11 comments
Labels
area: extensions/backends/gitlab area: extensions/backends exp: intermediate good first issue type: feature code contributing to the implementation of a feature and/or user facing functionality

Comments

@erezrokah
Copy link
Contributor

erezrokah commented Dec 7, 2021

Is your feature request related to a problem? Please describe.

Related to #5920.

Using the GitLab REST API can lead to performance issues and hitting rate limits.
Switching to GraphQL could help (we'll need to verify this).

Describe the solution you'd like
Similar to the GitHub backend, having use_graphql: true support for the GitLab backend

Describe alternatives you've considered
Keeping things as they are

Additional context
https://docs.gitlab.com/ee/api/graphql/

@imskr
Copy link

imskr commented Dec 9, 2021

@erezrokah I want to work on this issue. Please assign :)

@erezrokah
Copy link
Contributor Author

erezrokah commented Dec 9, 2021

Thanks @imskr, my suggestion is to start from the method in this comment #5920 (comment)

@imskr
Copy link

imskr commented Dec 11, 2021

Thanks @erezrokah so i have to create a new file GraphQLAPI.ts for this and add support for function #5920 (comment) right?

@erezrokah
Copy link
Contributor Author

Hi @imskr, I would even say start with the function in the comment and edit the current file, to see if it works first.
Once we can see the performance improvement we can think about separating the REST/GraphQL logic.

@imskr
Copy link

imskr commented Dec 16, 2021

@erezrokah can you give me a pointer on starting this?

@erezrokah
Copy link
Contributor Author

Hi @imskr, sorry for the delay to respond. I've started looking into this myself (digging into the GraphQL API) to get some clarity on what needs to be done.

I can update here once I make some progress.

@imskr
Copy link

imskr commented Dec 16, 2021

No worries @erezrokah let me know once you have something :)

@erezrokah
Copy link
Contributor Author

Hello 👋 Posted and update in #5920 (comment)

@imskr
Copy link

imskr commented Dec 17, 2021

Great @erezrokah I just checked it. I was looking for some good first issue if you can point me out that would be great 🙂 and also I can help on this on too though I'm new to the repo.

@erezrokah
Copy link
Contributor Author

Hi @imskr, I think #6061 could be a good first issue that's entry level (this issue is more intermediate). I added a comment on that issue to get people started

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: extensions/backends/gitlab area: extensions/backends exp: intermediate good first issue type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

No branches or pull requests

2 participants