Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(i18n): fix that unable to delete page with SINGLE_FILE i18n structure #6218

Merged
merged 1 commit into from
Feb 17, 2022
Merged

fix(i18n): fix that unable to delete page with SINGLE_FILE i18n structure #6218

merged 1 commit into from
Feb 17, 2022

Conversation

ManojBahuguna
Copy link
Contributor

@ManojBahuguna ManojBahuguna commented Feb 17, 2022 •
edited by erezrokah

fixes that getFilePaths returns same path twice when i18n structure is SINGLE_FILE

Checklist

  • I have read the contribution guidelines.
  • Code is formatted via running yarn format.
  • Tests are passing via running yarn test.
  • The status checks are successful (continuous integration). Those can be seen below.

A picture of a cute animal (not mandatory but encouraged)
image

@ManojBahuguna
fix(i18n): fix that unable to delete page with SINGLE_FILE i18n struc…
18b4ea1 
…ture


fixes that getFilePaths returns same path twice when i18n structure is SINGLE_FILE
@ManojBahuguna ManojBahuguna requested a review from a team February 17, 2022 09:58
@ManojBahuguna
Copy link
Contributor Author

Request Payload:
image

Response:
image

Error is because of delete action on same file is added twice.
I checked, passing just one action works fine.

@erezrokah erezrokah added type: chore work needed to keep the product and development running smoothly type: bug code to address defects in shipped code and removed type: chore work needed to keep the product and development running smoothly labels Feb 17, 2022
erezrokah
erezrokah approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ManojBahuguna ❤️

@erezrokah erezrokah merged commit a14580a into decaporg:master Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erezrokah erezrokah erezrokah approved these changes

Assignees
No one assigned
Labels
type: bug code to address defects in shipped code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ManojBahuguna @erezrokah