Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(@vtmn/css): VtmnRating stars out of the box with many reviews. #1440

Closed
tony3fk opened this issue Jun 12, 2023 · 3 comments
Closed

bug(@vtmn/css): VtmnRating stars out of the box with many reviews. #1440

tony3fk opened this issue Jun 12, 2023 · 3 comments
Labels
bug 🐛 Something isn't working community 👥 As we stopped improvements for this version of Vitamin, this issue needs to be done by the community CSS 🎨 Related to CSS styles packages question ❓ Further information is requested

Comments

@tony3fk
Copy link

tony3fk commented Jun 12, 2023

Describe the bug

Stars of VtmnRating component don't fit in the box when they have a lot of ratings and the mobile is 360px.
image

Steps to reproduce

On any page with a card carousel, staying in Viewport > 359px
Notice that each product carousel review star component is overflowing the box when there are many reviews.

Expected behavior

For example, one solution might be to add a wrapper to the flex container and center it. It could look like this:image

Browsers affected
- Chrome
- Firefox
- Edge
- Safari

Version affected

@vtmn/assets": "^1.1.1",
@vtmn/css-design-tokens": "^1.1.0",
@vtmn/css-tailwind-preset": "^1.1.2",
@vtmn/css-utilities": "^1.1.1",
@vtmn/icons": "^1.2.1",
@vtmn/svelte": "^2.0.1"

@tony3fk tony3fk added the bug 🐛 Something isn't working label Jun 12, 2023
@tony3fk tony3fk changed the title bug: bug (@vtmn-svelte): Jun 12, 2023
@tony3fk tony3fk changed the title bug (@vtmn-svelte): bug (@vtmn/css): VtmnRating stars out of the box with many reviews. Jun 12, 2023
@tony3fk tony3fk changed the title bug (@vtmn/css): VtmnRating stars out of the box with many reviews. bug(@vtmn/css): VtmnRating stars out of the box with many reviews. Jun 12, 2023
@lauthieb lauthieb added CSS 🎨 Related to CSS styles packages community 👥 As we stopped improvements for this version of Vitamin, this issue needs to be done by the community labels Jun 13, 2023
@lauthieb lauthieb changed the title bug(@vtmn/css): VtmnRating stars out of the box with many reviews. bug(@vtmn/css): VtmnRating stars out of the box with many reviews. Jun 13, 2023
@lauthieb
Copy link
Member

Thanks @tony3fk for reporting this.
@Sabrinavigil @SimonLeclercq @MARIEDELATTRE do you think the proposal of wrapping the number of notes below the rating (centered) could be okay for you? If yes, does this need to be done also on Figma with Auto-Layout?
Thanks in advance for your help.

@lauthieb lauthieb added the question ❓ Further information is requested label Jun 13, 2023
@MARIEDELATTRE
Copy link

Hi, for your context you should switch to the compact version of this component which is typically designed for this type of usecase.
CleanShot 2023-06-15 at 12 00 55@2x

@lauthieb
Copy link
Member

Thanks @MARIEDELATTRE for your answer to @tony3fk.
I close this issue accordingly.
Feel free to reopen if you feel that could not be possible or if you have another request.
Thank you again.

@lauthieb lauthieb closed this as not planned Won't fix, can't repro, duplicate, stale Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working community 👥 As we stopped improvements for this version of Vitamin, this issue needs to be done by the community CSS 🎨 Related to CSS styles packages question ❓ Further information is requested
Projects
Archived in project
Development

No branches or pull requests

3 participants