Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: sonarcloud analysis on Pull Requests #28

Closed
lauthieb opened this issue Dec 28, 2020 · 2 comments
Closed

bug: sonarcloud analysis on Pull Requests #28

lauthieb opened this issue Dec 28, 2020 · 2 comments
Assignees
@lauthieb
Labels
bug 🐛 Something isn't working config 🛠 Related to configuration

Comments

@lauthieb
Copy link
Member

lauthieb commented Dec 28, 2020 •
edited

Bug report

We need to launch Sonarcloud analysis in each PR.

Dashboard: https://sonarcloud.io/dashboard?id=Decathlon_vitamin-web
@lauthieb lauthieb added bug 🐛 Something isn't working config 🛠 Related to configuration labels Dec 28, 2020
@lauthieb lauthieb self-assigned this Dec 28, 2020
@lauthieb lauthieb changed the title bug: fix Sonarcloud analysis and results bug: fix Sonarcloud analysis on Pull Requests Dec 29, 2020
@lauthieb
Copy link
Member Author

lauthieb commented Dec 29, 2020 •
edited

@jlind23 FYI, the analysis does not launch even if we have code on main branch.
Example with this PR: #32

This check doesn't work. It overrides analysis on main instead of branch:
image

Proof: I've commited at 9:41pm on the PR and we have an update on main analysis inside dashboard at the same time:
image

@lauthieb lauthieb removed their assignment Dec 29, 2020
@lauthieb lauthieb mentioned this issue Dec 29, 2020
Closed
4 tasks
@lauthieb lauthieb linked a pull request Dec 29, 2020 that will close this issue
fix: sonarcloud analysis on Pull Requests #34
Closed
4 tasks
@lauthieb lauthieb removed a link to a pull request Dec 29, 2020
fix: sonarcloud analysis on Pull Requests #34
Closed
4 tasks
@lauthieb
Copy link
Member Author

Fixed here: 443b8c8

@lauthieb lauthieb self-assigned this Dec 30, 2020
@lauthieb lauthieb changed the title bug: fix Sonarcloud analysis on Pull Requests bug: sonarcloud analysis on Pull Requests Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lauthieb lauthieb

Labels
bug 🐛 Something isn't working config 🛠 Related to configuration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lauthieb