Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: error on pre-commit hook from Husky with lerna + lint-staged #48

Closed
lauthieb opened this issue Jan 13, 2021 · 1 comment · Fixed by #78
Closed

bug: error on pre-commit hook from Husky with lerna + lint-staged #48

lauthieb opened this issue Jan 13, 2021 · 1 comment · Fixed by #78
Assignees
Labels
bug 🐛 Something isn't working CSS 🎨 Related to CSS styles packages help wanted ✋ Extra attention is needed

Comments

@lauthieb
Copy link
Member

lauthieb commented Jan 13, 2021

Bug Report

We are facing a problem when we update a CSS file because the script stylelint:fix is failing when launched with lint-staged on pre-commit hook configured with Husky.

We should commit without add --no-verify

For example, to reproduce:

Thanks in advance for your help & thanks @gabbloquet for reporting me this too!

@lauthieb lauthieb added bug 🐛 Something isn't working CSS 🎨 Related to CSS styles packages help wanted ✋ Extra attention is needed labels Jan 13, 2021
@lauthieb
Copy link
Member Author

@jleveugle @thollander @crotru do you have any idea of resolution, please?

thollander added a commit that referenced this issue Jan 30, 2021
- stylelint doesn't need to be launched as a lerna command
- rules should be globalized at root level
- bug was coming from the script to be launched in a package where command doesn't exist

Closes #48
lauthieb pushed a commit that referenced this issue Jan 30, 2021
- stylelint doesn't need to be launched as a lerna command
- rules should be globalized at root level
- bug was coming from the script to be launched in a package where command doesn't exist

Closes #48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working CSS 🎨 Related to CSS styles packages help wanted ✋ Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants