Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle demos don't build zip with libs #103

Closed
ecumene opened this issue Jun 30, 2016 · 1 comment
Closed

Gradle demos don't build zip with libs #103

ecumene opened this issue Jun 30, 2016 · 1 comment

Comments

@ecumene
Copy link
Contributor

ecumene commented Jun 30, 2016

In the gradle demos, they don't build the plugin with the library dependencies.
demo_gradle/plugins/plugin1/build.gradle
demo_gradle/plugins/plugin2/build.gradle

A simple change in the build script could change this, I've got the solution in my app if you'd like me to create a pull request?

Or you can do it yourself in an upcoming commit:
From:

task plugin(type: Jar) {
    baseName = 'WelcomePlugin'
    version = '0.1.0'
    into('classes')
    extension('zip')
    with jar
}

To:

task plugin(type: Jar) {
    baseName = 'WelcomePlugin'
    version = '0.1.0'
    into('classes'){
         with jar
    }
    into('lib'){
        from configurations.compile
    }
    extension('zip')
}
assemble.dependsOn plugin // This is just so it builds the plugin with the build task

The code above should create two folders, lib and classes, in the plugin's zip. This has a little issue where it copies the API as a jar into lib but that can be fixed by adding a new configuration group called extraLibs

@decebals
Copy link
Member

decebals commented Jun 30, 2016

The Gradle demo was submitted by a contributor. I don't use Gradle in my projects so please submit a PR if something is wrong. I don't know if we need a readme file (in demo_gradle folder) to explain about how to build and run the demo with Gradle.
Thanks.

decebals added a commit that referenced this issue Jun 30, 2016
Fix for issue #103 and added the SLF4 Simple dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants