Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on JDK 1.8 #39

Merged
merged 2 commits into from May 27, 2015
Merged

Fix build on JDK 1.8 #39

merged 2 commits into from May 27, 2015

Conversation

lightglitch
Copy link
Contributor

No description provided.

@buildhive
Copy link

Decebal Suiu » pf4j #95 SUCCESS
This pull request looks good
(what's this?)

@@ -112,6 +112,15 @@

<profiles>
<profile>
<id>JDK 8 Build</id>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer an id without space characters (for example jdk8-build)

@lightglitch
Copy link
Contributor Author

Updated.

@buildhive
Copy link

Decebal Suiu » pf4j #97 SUCCESS
This pull request looks good
(what's this?)

decebals added a commit that referenced this pull request May 27, 2015
@decebals decebals merged commit 3aeefcd into pf4j:master May 27, 2015
@decebals
Copy link
Member

Thanks

@lightglitch lightglitch deleted the fix1.8 branch May 27, 2015 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants