Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added plugin archive source abstraction #41

Closed
wants to merge 2 commits into from
Closed

Added plugin archive source abstraction #41

wants to merge 2 commits into from

Conversation

lightglitch
Copy link
Contributor

Implements #31

@lightglitch lightglitch changed the title Plugin source Added plugin archive source abstraction May 27, 2015
@buildhive
Copy link

Decebal Suiu » pf4j #102 SUCCESS
This pull request looks good
(what's this?)

@decebals
Copy link
Member

I was very busy today. Tomorrow I will evaluate this PR.

@lightglitch
Copy link
Contributor Author

Take your time, is not urgent.

decebals added a commit that referenced this pull request Jun 5, 2015
@decebals
Copy link
Member

decebals commented Jun 5, 2015

See #43. Are you ok with my changes?

@decebals decebals closed this Jun 5, 2015
@lightglitch
Copy link
Contributor Author

It's only naming, right?
I didn't use Repository because could be confused with repository of https://github.com/decebals/pf4j-update but it's fine.

@decebals
Copy link
Member

decebals commented Jun 5, 2015

I didn't know that you know about pf4j-update 😄 In pf4j-update we have UpdateRepository.
I renamed PluginSource in PluginRepository, I moved FileFilter variable from DefaultPluginManager and PluginRepository methods in DefaultPluginRepository as constructor parameter. Also, I made PluginRepository pluggable in DefaultPluginManager with createPluginRepository method (you can override this method if you want).

decebals added a commit that referenced this pull request Jun 5, 2015
@lightglitch lightglitch deleted the plugin-source branch June 5, 2015 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants