Workaround for Issue #273

[barrantesgerman]

Hello

I investigated about server.join(); from the JettyServer.start() and tomcat.getServer().await(); from the TomcatServer.start()

In both cases the methods call Thread.join() and block the main thread of JUnit until the web server thread stops and release the main thread.

I searched how to make JUnit not work on the main thread, but I found nothing that would serve
I tried this and this

We must not comment server.join(); or tomcat.getServer().await(); because as AlexR says:

join() is blocking until server is ready. It behaves like Thread.join() and indeed calls join() of Jetty's thread pool. Everything works without this because jetty starts very quickly. However if your application is heavy enough the start might take some time. Call of join() guarantees that after it the server is indeed ready.

My final solution it's a workaround

JettyServer.start()

if (RuntimeMode.getCurrent() != RuntimeMode.TEST) {
    server.join();
}

TomcatServer.start()

if (RuntimeMode.getCurrent() != RuntimeMode.TEST) {
    tomcat.getServer().await();
}

According to many examples I saw on StackOverflow, in the case of JUnit you have to avoid server.join(); and as Joakim says is not needed for unit testing.

But I'm no expert in JUnit, I do not know what consequences might have

[coveralls]

Coverage decreased (-0.004%) to 11.019% when pulling c102fc6 on barrantesgerman:master into 6c6d0d7 on decebals:master.

[decebals]

@barrantesgerman Congratulation for your explanation! It's very documented. I see a little modification.
I prefer to use !pippoSettings.isTest() instead of RuntimeMode.getCurrent() != RuntimeMode.TEST. Please make the modification and I will merge this PR.
Thanks!

[coveralls]

Coverage decreased (-0.004%) to 11.019% when pulling e870246 on barrantesgerman:master into 6c6d0d7 on decebals:master.

[coveralls]

Coverage decreased (-0.004%) to 11.019% when pulling e870246 on barrantesgerman:master into 6c6d0d7 on decebals:master.

[decebals]

Thanks!