Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolating Hazelcast instance for each test #286

Merged
merged 4 commits into from
Jun 21, 2016
Merged

Isolating Hazelcast instance for each test #286

merged 4 commits into from
Jun 21, 2016

Conversation

barrantesgerman
Copy link
Contributor

I have made the suggested corrections

Any other recommendations is welcome

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling b578070 on barrantesgerman:master into * on decebals:master*.

@BeforeClass
public static void setUpClass() {
@Before
public void setUpClass() {
Copy link
Member

@decebals decebals Jun 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setUp() instead of setUpClass()?

@decebals
Copy link
Member

Test failed

@barrantesgerman
Copy link
Contributor Author

Yes, I will check

Use remove instead of delete to guarantee the replication in the cluster
Set 2 async backups to guarantee the copy in the unit test
@barrantesgerman
Copy link
Contributor Author

I think I found the problem

Use put instead of set to guarantee the replication in the cluster
Use remove instead of delete to guarantee the replication in the cluster
Set 2 async backups to guarantee the copy in the unit test

For more information
http://docs.hazelcast.org/docs/3.6/manual/html-single/index.html#backing-up-maps

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 4ac76c8 on barrantesgerman:master into * on decebals:master*.

@decebals decebals merged commit 401b16d into pippo-java:master Jun 21, 2016
@decebals
Copy link
Member

I see that you have fun doing these implementations 😄 I am sure that you learn a lot with this occasion.

@barrantesgerman
Copy link
Contributor Author

Yes, it is part of what I like about this job, I am forced to learn something new every day

@barrantesgerman
Copy link
Contributor Author

What would you like to be the next parent?

@decebals
Copy link
Member

The next parent can be pippo-content-type-parent. I prefer to work with short names, something similar with pippo-abc-parent but I feel that it's not possible right now (I don't know if we can change content-type with a simple word).

@barrantesgerman
Copy link
Contributor Author

I think the same, but right now can not think of another name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants