Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] When speeding up a txn, the loading status never updates #2604

Closed
1 of 2 tasks
cyaiox opened this issue Apr 11, 2023 · 1 comment
Closed
1 of 2 tasks

[BUG] When speeding up a txn, the loading status never updates #2604

cyaiox opened this issue Apr 11, 2023 · 1 comment
Assignees
Labels
bug Anything tagged under "fix"

Comments

@cyaiox
Copy link
Contributor

cyaiox commented Apr 11, 2023

🎉 Description

  • 🐛 This is a bug report.
  • 📈 This is a feature request.

📝 Details

When claiming a new name, if the network is slow and you speed up the txn, the UI keeps in a permanent loading status getting an error in the browser console:

TypeError: Cannot read properties of null (reading '_getInternalBlockNumber')
    at base-provider.ts:1417:21
    at Generator.next (<anonymous>)
    at 4.e5f597dd.chunk.js:8:3373250
    at new Promise (<anonymous>)
    at _ (4.e5f597dd.chunk.js:8:3372995)
    at getBlockNumber (4.e5f597dd.chunk.js:8:3391291)
    at M.<computed> (redux-saga-core.esm.js:524:21)
    at redux-saga-core.esm.js:1203:49
    at m (redux-saga-core.esm.js:1271:5)
    at p (redux-saga-core.esm.js:1161:9)

image.png

🔢 Steps To Reproduce Issue [ Good To Have ]

Please remember that with baby steps it's easier to reproduce the bug and it's much faster to fix it.

- Step 1) Claim a new name
- Step 2) When processing txn, speed up
- Step 3) UI keeps in a permanent loading state

👍 Other Information

image.png

@cyaiox cyaiox added the bug Anything tagged under "fix" label Apr 11, 2023
@cyaiox cyaiox assigned cyaiox and LautaroPetaccio and unassigned cyaiox Apr 14, 2023
@cyaiox
Copy link
Contributor Author

cyaiox commented Apr 14, 2023

Fixed in #2609

@cyaiox cyaiox closed this as completed Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Anything tagged under "fix"
Projects
None yet
Development

No branches or pull requests

2 participants