Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix video and audio streaming #322

Closed
2 tasks
pravusjif opened this issue Jun 7, 2022 · 6 comments
Closed
2 tasks

Fix video and audio streaming #322

pravusjif opened this issue Jun 7, 2022 · 6 comments
Labels
bug Something isn't working confirmed critical

Comments

@pravusjif
Copy link
Member

pravusjif commented Jun 7, 2022

Even after all the fixes already in place in our video player library, It has been reported in several issues that video and audio streaming has problems in the desktop client.

Audio Streaming

Apparently the video streaming audio only works for a couple of seconds and then it stops, this was reported by several users at Discord.

Video Streaming

Issue with the most information on the problem:

Other issues reporting the same problem:

Some coordinates in which the problem has been reported:

  • 2, 55
  • 110, -23
  • -17, -122
  • -22, 37
  • -94,103
  • -118,120

Approach

We'll try to solve the issue by integrating a unity plugin that apparently works with more formats than we can currently support on our own video player library. That task is tracked at

Acceptance Criteria

  • Finish integrating video player library solution in unity (and adding it to the building pipeline in a way that doesn't expose it as open-source since the plugin isn't open source)
  • Have video and audio streaming working correctly in the reported scenes
@Jusdem
Copy link

Jusdem commented Sep 8, 2022

Are there any updates on this, and how can we help?

@xavi-dcl
Copy link

@popuz this bug has been open for months. With the recent improvements to streaming, is it still relevant? If not, it would be great to verify and close this card.

@popuz
Copy link
Contributor

popuz commented Nov 10, 2022

hi @xavi-dcl . I was dealing with streaming in the browser which is a bit different. Desktop with AVPro was on the @dalkia hands. However, we will probably need to discuss it together to sync video codecs and formats which we use (when uploading is fully on our side)

@dalkia
Copy link
Contributor

dalkia commented Nov 10, 2022

Hi @xavi-dcl. We have implemented AVPro plugin in Desktop, and we didn't have a new report of videos not working there. This issue is safe to close.
Agreed with @popuz, we should set up that discussion.

@aixaCode
Copy link

Closing this issue, as the scope of the task has been completed.

@Jusdem
Copy link

Jusdem commented Nov 29, 2022

@aixaCode @pravusjif I've tested this and the streaming still does not work on desktop client.
Please test with this: https://livepeercdn.com/recordings/b77ff043-132c-4804-81b2-3cf7dafe5767/index.m3u8

Also, I'm using the latest desktop client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed critical
Projects
None yet
Development

No branches or pull requests

6 participants