Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overflow Analysis TODO Removal #13

Closed
cintixverum opened this issue Jul 21, 2017 · 2 comments
Closed

Overflow Analysis TODO Removal #13

cintixverum opened this issue Jul 21, 2017 · 2 comments

Comments

@cintixverum
Copy link

Line 127 of MANACrowdsale.sol:

// TODO: possibility of overflow in these operations should be analized

should be removed as there is no possibility of overflow. uint256 can store numbers larger than 10^77.

The line also contains a typo: analized should be analyzed.

It's also worth noting that the interest in the next two lines is calculated linearly instead of exponentially.

@kylerchin
Copy link

Stupid Overflow.

@federicobond
Copy link
Contributor

Yes, indeed, the 8% annual inflation is computed based on the supply at the end of the crowdsale and remains constant after that.

Thank you for taking a look at it @cintixverum!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants