Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS media queries inconsistency #145

Open
1emu opened this issue Mar 16, 2022 · 0 comments
Open

CSS media queries inconsistency #145

1emu opened this issue Mar 16, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@1emu
Copy link
Contributor

1emu commented Mar 16, 2022

We are using decentraland-ui for the Governance DAO project, and with @andyesp we noticed there is an inconsistency regarding how mobile/tablet styling is calculated.

Particularly for the Tabs.css, the way that mobile is determined is by querying for a max-width: 768px.

In the same project you are also defining a hook in Media.ts, useMobileMediaQuery, which uses a max-width of 767px for determining if something is mobile.

This causes for an unexpected behavior when switching to a tablet view with 768px, where some components display for tablet, but some styles are still applied as if they were mobile.

We suggest:

  • Change Tabs.css media query to max-width: 767px
  • Review and update all max-width: 768px media queries

If you agree that this is an issue, we can open a PR with the proposed solution.

@nicosantangelo nicosantangelo added the enhancement New feature or request label Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants