Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data-store-json): order credentials with weird issuanceDate #1273

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

mirceanis
Copy link
Member

@mirceanis mirceanis commented Oct 13, 2023

What is being changed

Some credentials from the wild are missing an issuanceDate, or have the date in a non-parseable format.
This fix defaults their date to unixtime(0) when compared to other credentials for database sorting.

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran pnpm i, pnpm build, pnpm test, pnpm test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests.
  • I added integration tests.
  • I did not add automated tests because only the data-store-json plugin accepts undefined issuanceDate.

Details

I added #1274 to demonstrate how a test for this might look like, but it would introduce a breaking change (if people use their own migrations)

@mirceanis mirceanis merged commit 28c65f7 into next Oct 13, 2023
9 checks passed
@mirceanis mirceanis deleted the blank-issuance-date branch October 13, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants